Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix core test RuntimeWarnings #97730

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Aug 3, 2023

Proposed change

Let's fix some pytest warnings!

 tests/test_core.py::test_serviceregistry_async_service_raise_exception
   /home/runner/work/ha-core/ha-core/tests/test_core.py:1250:
       RuntimeWarning: coroutine 'ServiceRegistry.async_call' was never awaited
   Coroutine created at (most recent call last)
     ...
     File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/asyncio/events.py", line 80, in _run
       self._context.run(self._callback, *self._args)
     File "/home/runner/work/ha-core/ha-core/tests/test_core.py", line 1250, in test_serviceregistry_async_service_raise_exception
       hass.services.async_call("test_domain", "REGISTER_CALLS", blocking=False)
     hass.services.async_call("test_domain", "REGISTER_CALLS", blocking=False)

 tests/test_core.py::test_serviceregistry_callback_service_raise_exception
   /home/runner/work/ha-core/ha-core/tests/test_core.py:1270:
       RuntimeWarning: coroutine 'ServiceRegistry.async_call' was never awaited
   Coroutine created at (most recent call last)
     ...
     File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/asyncio/events.py", line 80, in _run
       self._context.run(self._callback, *self._args)
     File "/home/runner/work/ha-core/ha-core/tests/test_core.py", line 1270, in test_serviceregistry_callback_service_raise_exception
       hass.services.async_call("test_domain", "REGISTER_CALLS", blocking=False)
     hass.services.async_call("test_domain", "REGISTER_CALLS", blocking=False)

Add missing await for hass.service.async_call(...).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Aug 3, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

../Frenck

@frenck frenck merged commit c33e3ce into home-assistant:dev Aug 4, 2023
33 of 34 checks passed
@cdce8p cdce8p deleted the warnings-core branch August 4, 2023 09:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants